-
Notifications
You must be signed in to change notification settings - Fork 9.9k
Add links to Python packages docs #24045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
irvinebroque
wants to merge
1
commit into
production
Choose a base branch
from
bib/python-packages-links
base: production
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -9,10 +9,10 @@ head: | |||||
| import { Render } from "~/components"; | ||||||
|
|
||||||
| [Pywrangler](https://github.com/cloudflare/workers-py?tab=readme-ov-file#pywrangler) is a CLI tool for managing packages and Python Workers. | ||||||
| It is meant as a wrapper for wrangler that sets up a full environment for you, including bundling your packages into | ||||||
| It is meant as a wrapper for [Wrangler CLI](/workers/wrangler/) that sets up a full Python virtual environment for you, including bundling your packages into | ||||||
| your worker bundle on deployment. | ||||||
|
|
||||||
| To get started, create a pyproject.toml file with the following contents: | ||||||
| To get started, create a `pyproject.toml` file with the following contents: | ||||||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if we should clarify that you should still put any Workers specific config in a
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| ```toml | ||||||
| [project] | ||||||
|
|
@@ -28,7 +28,7 @@ dependencies = [ | |||||
| dev = ["workers-py"] | ||||||
| ``` | ||||||
|
|
||||||
| The above will allow your worker to depend on the [FastAPI](https://fastapi.tiangolo.com/) package. | ||||||
| The above will allow your Worker to depend on the [FastAPI](https://fastapi.tiangolo.com/) package. | ||||||
|
|
||||||
| To run the worker locally: | ||||||
|
|
||||||
|
|
@@ -44,7 +44,7 @@ uv run pywrangler deploy | |||||
|
|
||||||
| Your dependencies will get bundled with your worker automatically on deployment. | ||||||
|
|
||||||
| The `pywrangler` CLI also supports all commands supported by the `wrangler` tool, for the full list of commands run `uv run pywrangler --help`. | ||||||
| `pywrangler` also supports all [commands supported by Wrangler](/workers/wrangler/commands/). For the full list of commands run `uv run pywrangler --help`. | ||||||
|
|
||||||
| ## HTTP Client Libraries | ||||||
|
|
||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dom96 is this part true? What we're doing versus what
uvis doing re virtual env?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think true w this edit and also provides context on uv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, with that edit it makes sense.