-
Notifications
You must be signed in to change notification settings - Fork 9.9k
[Docs] Mirage deprecation follow-up #24199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR requires additional review attention because it affects the following areas: PartialsThis PR updates partial files, which are pieces of content used across multiple files in our Render component.
|
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this change to the PR for that doc to avoid a merge conflict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will delete the page when merged, which is probably something we do not want. It will also break the build, since we still have pages pointing to the deleted page.
Ideally we'd merge your changes in #25144 first, then merge the production branch into this PR's source branch.
Alternatively, let's just remove any changes I initially made to the src/content/docs/speed/optimization/images/mirage.mdx file but keep the file.
1531bbf to
8a5038c
Compare
Summary
Follow-up of #24174.