Skip to content

[DO] Update code example for WebSocket hibernation #24286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025

Conversation

redacor
Copy link
Contributor

@redacor redacor commented Aug 9, 2025

Summary

I think this example is meant to show how to broadcast a message to all connected clients, but the message sender is incorrectly identified.

Documentation checklist

@github-actions github-actions bot added the product:durable-objects Durable Objects: https://developers.cloudflare.com/workers/learning/using-durable-objects/ label Aug 9, 2025
@Oxyjun
Copy link
Contributor

Oxyjun commented Aug 11, 2025

Thanks for the PR @redacor !

We've tested it and will merge it in 😄

@Oxyjun Oxyjun merged commit bfb3ce1 into cloudflare:production Aug 11, 2025
5 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Aug 11, 2025
Copy link

holopin-bot bot commented Aug 11, 2025

Congratulations @redacor, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cme70u112096507l9ae9dpgrv

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@redacor redacor deleted the update-ws-hibernation-example branch August 11, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes a docs contribution, big or small product:durable-objects Durable Objects: https://developers.cloudflare.com/workers/learning/using-durable-objects/ size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants