Skip to content

[Chore] Fix rendering bug on plans page #24304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2025
Merged

[Chore] Fix rendering bug on plans page #24304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d05c5d6
[Chore] Fix rendering bug on plans page
kodster28 Aug 11, 2025
31b46e9
unused import
kodster28 Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 1 addition & 26 deletions src/components/FeatureTable.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import { z } from "astro:schema";
import { indexPlans } from "~/util/plans";
import { marked } from "marked";
import GlossaryTooltip from "~/components/GlossaryTooltip.astro";

type Props = z.infer<typeof props>;

Expand Down Expand Up @@ -46,33 +45,9 @@ const markdown = (content: any) => {
<tbody>
{
features.map((feature) => {
const renderTitle = (title: string) => {
const placeholder = "[[GLOSSARY_TOOLTIP_SNIPPETS_SUBREQUEST]]";

if (title.includes(placeholder)) {
const [beforePlaceholder, afterPlaceholder] =
title.split(placeholder);

return (
<>
{beforePlaceholder}
<GlossaryTooltip
term="Snippets subrequest"
prepend="A subrequest is "
>
subrequests
</GlossaryTooltip>
{afterPlaceholder}
</>
);
}

return markdown(title);
};

return (
<tr>
<th set:html={renderTitle(feature.title)} />
<th set:html={markdown(feature.title)} />
{hasFree && <td set:html={markdown(feature.free)} />}
{hasPro && <td set:html={markdown(feature.pro)} />}
{hasBiz && <td set:html={markdown(feature.biz)} />}
Expand Down
4 changes: 2 additions & 2 deletions src/content/plans/index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1368,7 +1368,7 @@
"ent": 300
},
"subrequests": {
"title": "Number of [[GLOSSARY_TOOLTIP_SNIPPETS_SUBREQUEST]]",
"title": "Number of snippet subrequests",
"free": 0,
"pro": 2,
"biz": 3,
Expand Down Expand Up @@ -2785,7 +2785,7 @@
"pro": "No",
"biz": "No",
"ent": "Contact your account team"
},
},
"custom_certificates": {
"title": "[Custom certificates](/cloudflare-for-platforms/cloudflare-for-saas/security/certificate-management/custom-certificates/)",
"free": "No",
Expand Down
Loading