Remove calls to sql.end() in Hyperdrive examples #24429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed, the workers runtime already handles closing outgoing connections as soon as a worker invocation finishes. And we have reason to believe that sql.end() can cause hangs due to a bug in postgres.js, so it's better to just not include it. I guess I didn't have to remove it from our node-postgres examples, but it isn't needed there either, so why clutter our examples with extra code?
a-robinson
requested review from
a team,
GregBrimble,
Oxyjun,
WalshyDev,
elithrar,
irvinebroque,
kodster28,
korinne,
mikenomitch,
sejoker and
thomasgauvin
as code owners
github-actions
bot
added
product:hyperdrive
github-actions
bot
assigned
GregBrimble,
irvinebroque,
kodster28,
korinne,
mikenomitch and
WalshyDev
Oxyjun
approved these changes
Aug 15, 2025
thomasgauvin
pushed a commit
that referenced
this pull request
Aug 15, 2025
As discussed, the workers runtime already handles closing outgoing connections as soon as a worker invocation finishes. And we have reason to believe that sql.end() can cause hangs due to a bug in postgres.js, so it's better to just not include it. I guess I didn't have to remove it from our node-postgres examples, but it isn't needed there either, so why clutter our examples with extra code?
maxvp
pushed a commit
that referenced
this pull request
Aug 24, 2025
As discussed, the workers runtime already handles closing outgoing connections as soon as a worker invocation finishes. And we have reason to believe that sql.end() can cause hangs due to a bug in postgres.js, so it's better to just not include it. I guess I didn't have to remove it from our node-postgres examples, but it isn't needed there either, so why clutter our examples with extra code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, the workers runtime already handles closing outgoing connections as soon as a worker invocation finishes. And we have reason to believe that sql.end() can cause hangs due to a bug in postgres.js (porsager/postgres#1097), so it's better to just not include it.
I guess I didn't have to remove it from our node-postgres examples, but it isn't needed there either, so why clutter our examples with extra code?
@thomasgauvin @ReppCodes