-
Notifications
You must be signed in to change notification settings - Fork 9.9k
[Workers] changelog for new wrangler error screen #24456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
Preview URL: https://c70f7e3a.preview.developers.cloudflare.com Files with changes (up to 15) |
irvinebroque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we show old vs. new on this side by side?
| |-------------|------------| | ||
| |  |  | | ||
|
|
||
| These improvements are available now in the latest version of Wrangler during local development. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we give people CLI command to run, ex: npx wrangler@latest dev — show vs. tell people how to run latest version of wrangler
| @@ -0,0 +1,18 @@ | |||
| --- | |||
| title: Better error screen coming to Wrangler | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikenomitch title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Streamline your debugging with improved Wrangler error screen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe Easier debugging in Workers with improved Wrangler error screen
@lrapoport-cf I just personally don't like streamline for whatever reason (sounds a big corporate), and then added Workers just in case people don't know Wrangler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the title as Mike suggested. We can publish later today if no other issues come up. Thanks everyone for the input!
|
I am still looking into why the screenshot ratios do not match, but here is a first pass showing how they render side by side. |
irvinebroque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Summary
This adds a changelog entry for some of the works we did on the wrangler error screen.
Todos:
Screenshots (optional)
Documentation checklist