Fixes to Python debugging-logs example #24479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `traceback.format_exc()` returns a string so we shouldn't json.dumps() it. * `traceback.format_exc()` should always return a truthy value so `or e` does nothing. * The coroutine returned by `post_log()` is not callable so it doens't make sense to call `create_once_callable()` on it. We want `create_proxy()`. * extract post_log function to top level * explicitly convert error to string for clarity when assigning to headers * `str(e)` already includes a traceback so we don't need to include a separate traceback here
hoodmane
requested review from
a team,
GregBrimble,
WalshyDev,
irvinebroque,
kodster28,
korinne and
mikenomitch
as code owners
github-actions
bot
assigned
GregBrimble,
irvinebroque,
kodster28,
korinne,
mikenomitch and
WalshyDev
dom96
approved these changes
Aug 18, 2025
kodster28
approved these changes
Aug 19, 2025
maxvp
pushed a commit
that referenced
this pull request
Aug 24, 2025
* `traceback.format_exc()` returns a string so we shouldn't json.dumps() it. * `traceback.format_exc()` should always return a truthy value so `or e` does nothing. * The coroutine returned by `post_log()` is not callable so it doens't make sense to call `create_once_callable()` on it. We want `create_proxy()`. * extract post_log function to top level * explicitly convert error to string for clarity when assigning to headers * `str(e)` already includes a traceback so we don't need to include a separate traceback here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
traceback.format_exc()returns a string so we shouldn't json.dumps() it.traceback.format_exc()should always return a truthy value soor edoes nothing.post_log()is not callable so it doens't make sense to callcreate_once_callable()on it. We wantcreate_proxy().str(e)already includes a traceback so we don't need to include a separate traceback herecc @dom96