Skip to content

[Workers] Fix sample code in timers document #24958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 5, 2025
Merged

[Workers] Fix sample code in timers document #24958

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
656f040
[Workers] Fix destructuring of promise resolvers in timers example
nzws Sep 5, 2025
6a93d53
[Workers] Tweak code sample in timers document
nzws Sep 5, 2025
201fc59
[Workers] Remove unused code block from timers document
nzws Sep 5, 2025
7f171da
[Workers] Fix type parameter for Promise.withResolvers in timers example
nzws Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/content/docs/workers/runtime-apis/nodejs/timers.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ and [`setImmediate`](https://nodejs.org/api/timers.html#setimmediatecallback-arg
import timers from "node:timers";

export default {
async fetch() {
async fetch(): Promise<Response> {
console.log("first");
const { promise1, resolve1 } = Promise.withResolvers();
const { promise2, resolve2 } = Promise.withResolvers();
const { promise: promise1, resolve: resolve1 } = Promise.withResolvers<void>();
const { promise: promise2, resolve: resolve2 } = Promise.withResolvers<void>();
timers.setTimeout(() => {
console.log("last");
resolve1();
Expand All @@ -35,10 +35,8 @@ export default {
await Promise.all([promise1, promise2]);

return new Response("ok");

}
}

}
} satisfies ExportedHandler<Env>;
```
</TypeScriptExample>

Expand All @@ -55,4 +53,3 @@ compatibility, you must call functions from the `node:timers` module.
:::

The full `node:timers` API is documented in the [Node.js documentation for `node:timers`](https://nodejs.org/api/timers.html).
```
Loading