Skip to content

Conversation

@guybedford
Copy link
Contributor

Summary

Provides a technical changelog for the new workers-rs panic recovery functionality.

It's quite nice to go into the details here, but we could cut back on the content too if this is the wrong place for it.

Screenshots (optional)

Documentation checklist

  • Is there a changelog entry (guidelines)? If you don't add one for something awesome and new (however small) — how will our customers find out? Changelogs are automatically posted to RSS feeds, the Discord, and X.
  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

Copy link
Contributor

@irvinebroque irvinebroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome and think it is good to get into this kind of detail here

Copy link

@JohnDaWalka JohnDaWalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

Copy link
Contributor

@danlapid danlapid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE IT

Copy link
Contributor

@mikenomitch mikenomitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guybedford this feels more like part of a blog post or docs than a Changelog.

Instead of going into the details (at least initially), I'd make it much more to the point:

  • Previously, when in workers-rs when a Rust panic occured, X would happen. This was bad because the Worker would then do Y.
  • Now you can add the new setPanicHook functionality to handle these errors.

I thin we can and should go a little into the details after this, but I'd probably try to trim it down a bit from where its at.

Also, I see setPanicHook being imported from index.js. It's not clear to me where it actually comes from and how to implement. Is there a way to add some more color there?

EDIT: Brendan and Dan seemed more into including the details here than I was. 😄 - I'm okay keeping what we have as long as they don't interfere with immediately defining the problem and how we now solve it. So I'd push the wasm-bindgen bits down below, and explain "Wasm is a virtual machine" later too, and then I think its good.

@mikenomitch mikenomitch enabled auto-merge (squash) September 19, 2025 21:35
@mikenomitch mikenomitch merged commit 8f26006 into cloudflare:production Sep 19, 2025
2 checks passed
@guybedford guybedford deleted the workers-rs-panics branch September 19, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants