-
Notifications
You must be signed in to change notification settings - Fork 9.9k
Thomasgauvin housekeeping #25308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thomasgauvin housekeeping #25308
Conversation
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
src/content/docs/workers-vpc/configuration/tunnel/hardware-requirements.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers-vpc/configuration/tunnel/hardware-requirements.mdx
Outdated
Show resolved
Hide resolved
|
the http routing through the binding fetch just uses the protocol component? ie http urls go to the service http port (if defined), and https urls go to the service https port (if defined), and the other components (hostname/port) are ignored/sent-on (reminds me of DO requests) |
| --- | ||
| productName: Workers VPC | ||
| entries: | ||
| - term: Virtual Private Cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: We already have a very similar entry (Virtual Private Cloud (VPC)) in the Zero Trust glossary:
https://github.com/cloudflare/cloudflare-docs/blob/production/src/content/glossary/cloudflare-one.yaml?plain=1#L272
Would it make sense to update the existing definition instead of creating a new entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I don't see the glossary in the docs, this file might not be being used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The global glossary is available here:
https://developers.cloudflare.com/glossary/
Co-authored-by: Pedro Sousa <[email protected]>
|
|
||
| The information provided in the `fetch()` operation is not used to route requests, and instead only populates the `Host` field for a HTTP request that can be parsed by the server and used for Server Name Indication (SNI). | ||
| ::: | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomasgauvin we should document that app services features (caching, image transformations, etc) on VPC Service fetch are not supported?
| For production use cases, we recommend the following baseline configuration: | ||
|
|
||
| - Run a cloudflared replica on two dedicated host machines per network location. Using two hosts enables server-side redundancy. See [tunnel availability and replicas](/cloudflare-one/networks/connectors/cloudflare-tunnel/configure-tunnels/tunnel-availability/) for setup instructions. | ||
| - Size each host with minimum 4GB of RAM and 4 CPU cores. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems excessive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| To estimate tunnel capacity requirements for your deployment, refer to the [tunnel capacity calculator in the Zero Trust documentation](/cloudflare-one/networks/connectors/cloudflare-tunnel/configure-tunnels/tunnel-availability/system-requirements/). | ||
|
|
||
| ## Scaling considerations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd drop this, I'm not sure these recommendations are useful compared to the capacity calculator. I'd rather see documentation for metrics reported by tunnel and how to monitor if the tunnel deployment needs more resources
Co-authored-by: Matt <[email protected]>
Co-authored-by: Matt <[email protected]>
Co-authored-by: Matt <[email protected]>
Co-authored-by: Matt <[email protected]>

No description provided.