-
Notifications
You must be signed in to change notification settings - Fork 9.9k
Access on Workers docs #25603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access on Workers docs #25603
Conversation
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
39452b7 to
6b94fa0
Compare
irvinebroque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| try { | ||
| // Create JWKS from your team domain | ||
| const JWKS = createRemoteJWKSet( | ||
| new URL(`${env.TEAM_DOMAIN}/cdn-cgi/access/certs`), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like including the code snippet in the changelog, and the guidance
If we are going to do that we might need to guide people though on (1) where these env vars come from and (2) how to set them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or alternatively — just link there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, sorry, missed those from my copy-paste of your code snippet. Adding now! (I think good to copy rather than just link so it's all in one place and pads the changelog out a bit).
|
|
||
| All Workers are assigned a `workers.dev` route when they are created or renamed following the syntax `<YOUR_WORKER_NAME>.<YOUR_SUBDOMAIN>.workers.dev`. The [`name`](/workers/wrangler/configuration/#inheritable-keys) field in your Worker configuration is used as the subdomain for the deployed Worker. | ||
|
|
||
| ## Manage access to `workers.dev` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one adding this here
irvinebroque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ so you have it
829c790 to
e9b64f3
Compare

Summary
Changelog and docs for Access in front of Workers
Documentation checklist