Removed section on Durable Object alarms from known issues#28706
Removed section on Durable Object alarms from known issues#28706emily-shen wants to merge 1 commit intoproductionfrom
Conversation
Removed section on Durable Object alarms from known issues. cloudflare/workerd#1918
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
Preview URL: https://d189a5eb.preview.developers.cloudflare.com Files with changes (up to 15) |
|
/bonk review this and make sure no other mentions of this now outdated notice |
There was a problem hiding this comment.
No issues found. The removed section is the only mention of this specific known issue (alarms not being reset between test runs / not respecting isolated storage). No other pages reference this limitation — the remaining runDurableObjectAlarm() mentions in test-apis.mdx, testing-with-durable-objects.mdx, and the migration guide are standard API documentation, not caveats about the bug.
|
No issues found. The PR cleanly removes the 4-line "Durable Object alarms" known issue section. I searched across the entire
The removal is self-contained and leaves no stale references. |
|
|
||
| ### Durable Object alarms | ||
|
|
||
| Durable Object alarms are not reset between test runs and do not respect isolated storage. Ensure you delete or run all alarms with [`runDurableObjectAlarm()`](/workers/testing/vitest-integration/test-apis/#durable-objects) scheduled in each test before finishing the test. |
There was a problem hiding this comment.
this is great and worth sharing @MattieTK - people love to hear about stuff we are fixing
penalosa
left a comment
There was a problem hiding this comment.
The workerd PR is being reverted as part of cloudflare/workerd#6104, since isolated storage no longer exists
|
Hey there, we've marked this pull request as stale because there's no recent activity on it. This label is helps us identify PRs that might need updates (or to be closed out by our team if no longer relevant). |
Removed section on Durable Object alarms from known issues.
fixed here cloudflare/workerd#1918
pending that version of workerd getting merged into workers-sdk
Summary
Screenshots (optional)
Documentation checklist