style: header design improvements#29123
Merged
MohamedH1998 merged 6 commits intostyle/sidebar-improvementsfrom Mar 20, 2026
Merged
style: header design improvements#29123MohamedH1998 merged 6 commits intostyle/sidebar-improvementsfrom
MohamedH1998 merged 6 commits intostyle/sidebar-improvementsfrom
Conversation
MohamedH1998
changed the base branch from
production
to
style/sidebar-improvements
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
CI run failed: build logs |
Contributor
|
Preview URL: https://c4af90db.preview.developers.cloudflare.com |
MohamedH1998
force-pushed
the
style/header-improvements
branch
from
43bdb92 to
282b4e6
Compare
Contributor
|
/bonk please review |
Contributor
|
The header design improvements look solid. The changes introduce theme-aware CSS variables, improve responsive behavior with the 800px breakpoint, and organize the header structure more cleanly. Summary:
Observations:
No issues found. The preview at https://b97cbfca.preview.developers.cloudflare.com should show the improved header design. |
mvvmm
approved these changes
Mar 20, 2026
* style: toc design improvements * fix: keyboard nav in feedback form * fix: decrease textarea rows * fix: vertical alignment of the toc * Update src/components/overrides/TableOfContents.astro Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com> --------- Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
MohamedH1998
merged commit 3a4d0dd
into
style/sidebar-improvements
1 of 2 checks passed
MohamedH1998
added a commit
that referenced
this pull request
Mar 20, 2026
* style: improve sidebar item layout, focus style, and spacing * fix: change icon path * fix: revert icon path * fix: fix build error * style: PR comment fixes * style: refine sidebar * style: show active state in parents of nested items * fix: ci failure * style: improve theming * fix: improve animation * Update src/components/overrides/SidebarSublist.astro Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com> * style: header design improvements (#29123) * style: header design tweaks * fix: align vertically * style: toc design improvements (#29124) * style: toc design improvements * fix: keyboard nav in feedback form * fix: decrease textarea rows * fix: vertical alignment of the toc * Update src/components/overrides/TableOfContents.astro Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com> --------- Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com> --------- Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com> --------- Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots (optional)
Before
After
Screen recording
Screen.Recording.2026-03-19.at.22.49.40.mov
Documentation checklist