Prevent CLRF line endings with pre-commit hook

[mvvmm]

Summary

• Pre-commit hook that forces LF line endings
• CI check stolen from Add CI check for CRLF line endings #27186

[github-actions]

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern	Owners
/.github/	@cloudflare/content-engineering, @kodster28, @mvvmm, @colbywhite, @ahaywood
*	@cloudflare/pcx-technical-writing
package.json	@cloudflare/content-engineering

[mvvmm]

/bonk do you see any issues with this?

[ask-bonk]

Reviewing this PR that adds a Husky pre-commit hook for LF line endings.

Findings:

The PR adds a pre-commit hook that:

• Detects CRLF line endings in staged files
• Converts them to LF using perl (cross-platform compatible)
• Re-stages the fixed files

The implementation is solid with proper handling for:

• Empty staging area (early exit)
• Deleted files (skips non-existent files)
• Both CRLF and standalone CR characters

Minor issue:

Line 14 in .husky/pre-commit - Unquoted variable could break on filenames with spaces:

if [ ! -f "$file" ]; then

This is already correct. However, line 13 and line 20 also use $file and should be checked:

for file in $STAGED; do  # Line 13 - will break on spaces

And line 20:

if grep -qU $'\r' "$file"; then  # Line 20 - correctly quoted

Recommendation:

Line 13 should handle word splitting properly. The for file in $STAGED loop will break if filenames contain spaces. Consider:

while IFS= read -r file; do
  # ... existing logic ...
done <<< "$STAGED"

Overall assessment:

The hook is a useful defense-in-depth addition alongside the existing .gitattributes configuration. Good protection against AI tools and Windows environments introducing CRLF. The package.json changes (adding husky dependency and prepare script) are correct.

LGTM with the minor note about filename handling. The space-in-filename issue is an edge case but worth addressing for robustness.

github run

[mvvmm]

/bonk please review

[ask-bonk]

One minor suggestion on the caching configuration.

[ask-bonk]

Posted 1 suggestion on the node_modules cache key.

The pre-commit hook looks solid—properly handles filenames with spaces, deleted files, and cross-platform compatibility. Good defense alongside .gitattributes.

github run

[github-actions]

Preview URL: https://735b8ddf.preview.developers.cloudflare.com
Preview Branch URL: https://line-ending-commit-hook.preview.developers.cloudflare.com