fix: improve JSON-LD org structured data - #32932
Open
mvvmm wants to merge 7 commits into
Open
Conversation
Contributor
Review💡 1 suggestion found in commit 👉 Fix in your agent 👈Fix the following review findings in PR #32932 (https://github.com/cloudflare/cloudflare-docs/pull/32932).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Suggestions (1)
#### CR-11073ca56cf3 · Brittle exact-output assertion
- **File:** `src/util/page-head.node.test.ts` line 268
- **Issue:** The test asserts byte-for-byte equality against a ~1.4 KB hand-written JSON string. Any change to organization details (e.g. publisher description, address, contact points) will force a manual update of this single long literal.
- **Fix:** Use `toMatchInlineSnapshot()` or `toMatchSnapshot()` instead of `toBe(<huge literal>)` so snapshot tooling can update the expected output automatically when the serialized JSON-LD changes intentionally.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Suggestions (1)
ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://jsonld-homepage-webpage-cloudflare-docs.cloudflare-docs.workers.dev (commit 9b2c944)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Contributor
|
Preview URL: https://9b2c944a.preview.developers.cloudflare.com |
mvvmm
changed the title
mvvmm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.