fix s3 streaming uploads broken by go/net bump #1512
+4
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1511
cloudflared sets
NoBody
for non chunked and zero content length requests as seen below:However, when
content-length
is not set, it defaults to0
, and AWS S3 usescontent-encoding: aws-chunked
instead oftransfer-encoding
, causing cloudflared to setNoBody
.With the go/net module 0.26.0->0.40.0 bump, it explicitly sets
content-length: 0
if request is NoBody here, even when original request does not have acontent-length
header. This causes S3-compatible storages, at least minio, and potentially other applications to fail, because the uploaded body size does not match the header.The fix simply searches the string
chunked
incontent-encoding
alongsidetransfer-encoding
, in order to skip setting NoBody.