Refactors to prepare for moving the aggregation logic back into the workers#747
Merged
Refactors to prepare for moving the aggregation logic back into the workers#747
Conversation
mendess
requested review from
RageKnify,
armfazh,
bhalleycf,
cbranch,
cjpatton,
fisherdarling,
jhoyla and
lbaquerofierro
as code owners
jhoyla
reviewed
Dec 19, 2024
mendess
force-pushed
the
mendess/small-changes
branch
2 times, most recently
from
a717a8f to
65b0086
Compare
cjpatton
reviewed
Dec 19, 2024
mendess
force-pushed
the
mendess/small-changes
branch
2 times, most recently
from
0241bee to
f76357e
Compare
cjpatton
reviewed
Jan 1, 2025
mendess
force-pushed
the
mendess/small-changes
branch
from
f76357e to
3f9f5a1
Compare
cjpatton
reviewed
Jan 3, 2025
Contributor
cjpatton
left a comment
cjpatton
left a comment
There was a problem hiding this comment.
Looks good except for the two remaining comments.
mendess
force-pushed
the
mendess/small-changes
branch
2 times, most recently
from
0237ebc to
16be6a7
Compare
mendess
force-pushed
the
mendess/small-changes
branch
from
16be6a7 to
4739207
Compare
Collaborator
Author
done |
cjpatton
approved these changes
Jan 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.