daphne: Remove 16-byte VdafVerifyKey variant#761
Merged
Conversation
Merged
cjpatton
requested review from
RageKnify,
armfazh,
bhalleycf,
cbranch,
fisherdarling,
jhoyla,
lbaquerofierro and
mendess
as code owners
mendess
requested changes
Jan 14, 2025
This length was required for Prio3 by VDAF-09. However, we only support variants of Prio3 in VDAF-09 that use the custom XOF, which has a 32-byte key. Also, once Mastic support is fully implemented, it will also use a 32-byte key.
cjpatton
force-pushed
the
cjpatton/vdaf-key-size
branch
from
fbb4663 to
9fdc493
Compare
mendess
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This length was required for Prio3 by VDAF-09. However, we only support variants of Prio3 in VDAF-09 that use the custom XOF, which has a 32-byte key.
Also, once Mastic support is fully implemented, it will also use a 32-byte key.