Re-export Hyper types used in public API #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheJokr
force-pushed
the
thea/reexport-http-method
branch
from
0c23ef9 to
cd81124
Compare
Foundations uses Hyper types in it's public API for `TelemetryServerRoute` which means any users will need to add an explicit dependency on the same version of hyper and ensure it stays matching. Re-exporting the types will allow users to explicitly use the same types as foundations is using. For simplicity, we re-export the entire `hyper` crate under a new `foundations::telemetry::reexports` module.
TheJokr
force-pushed
the
thea/reexport-http-method
branch
from
cd81124 to
379000f
Compare
|
Rebased and altered the PR slightly. The hyper 1.x bump meant that body handling got quite a bit more complicated, so we would need to export more types. Instead, I chose to re-export all of |
TheJokr
reviewed
Aug 27, 2025
fisherdarling
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foundations uses Hyper types in it's public API for
TelemetryServerRoutewhich means any users will need to add an explicit dependency on the same version of hyper and ensure it stays matching. Re-exporting the types will allow users to explicitly use the same types as foundations is using.