feat: allow manually shutting down logging from TelemetryDriver#168
Closed
AkshatM wants to merge 0 commit intocloudflare:mainfrom
Closed
feat: allow manually shutting down logging from TelemetryDriver#168AkshatM wants to merge 0 commit intocloudflare:mainfrom
AkshatM wants to merge 0 commit intocloudflare:mainfrom
Conversation
AkshatM
force-pushed
the
main
branch
3 times, most recently
from
014fd09 to
4c1e7ee
Compare
Contributor
Author
|
Received confirmation from @hanglowan that this fix resolves the log flush behaviour as expected by calling |
TheJokr
reviewed
Feb 17, 2026
Collaborator
TheJokr
left a comment
TheJokr
left a comment
There was a problem hiding this comment.
Thank you! LGTM, just some nits.
AkshatM
force-pushed
the
main
branch
2 times, most recently
from
e00b694 to
9e3ad8a
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #114, which describes the bug in detail. slog provides an
AsyncGuardimplementation which is designed to ensure log flushes on drops even if theAsynclogger is captured in a global variable.To ensure backwards compatibility, we now return an AsyncGuard that can be manually dropped, allowing existing users to continue to rely on current semantics but guarantee logging is shut down when desired. Credit to @TheJokr for the suggestion.
The most complicated part of this feature is its interaction with the
loggingfeature. Since it only makes sense ifloggingis enabled, I have conditionally compiled accordingly.