Implement TLS Flags and the request mTLS flag. #191
Merged
+222
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoyla
force-pushed
the
jhoyla/tls-flags-rebase
branch
from
e05cbae to
5324115
Compare
Member
|
Confirmed except for the new commit it's a rebase. |
jhoyla
force-pushed
the
jhoyla/tls-flags-rebase
branch
from
5324115 to
e13e0de
Compare
bwesterb
approved these changes
May 6, 2025
jhoyla
force-pushed
the
jhoyla/tls-flags-rebase
branch
2 times, most recently
from
d64905b to
08059b3
Compare
cjpatton
approved these changes
May 6, 2025
Contributor
cjpatton
left a comment
cjpatton
left a comment
There was a problem hiding this comment.
Looks good! I have some comments on style, plus some improvements for testing I'd strongly recommend. Feel free to merge when you're happy.
Comment on lines
+945
to
+949
| for _, flag := range hs.tlsFlags { | ||
| if flag == ExperimentalFlagSupportMTLS { | ||
| return true | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Suggestion, feel free to ignore: I feel like it ought to be possible to do this without iterating over the set flags. Can't we just do some bit fiddling on the the encoded TLS flags to see if the req mTLS flag is set?
jhoyla
force-pushed
the
jhoyla/tls-flags-rebase
branch
from
e5a732d to
7d3a695
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for sending and receiving TLS Flags, and support for the request mTLS flag.