-
Notifications
You must be signed in to change notification settings - Fork 13
Update Kotlin 1 -> 2 and support ES Modules #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update Kotlin 1 -> 2 and support ES Modules #10
Conversation
d811305
to
c5559f1
Compare
I didn't saw your PR when I created mine. Unfortunately
Also, please consider removing the ./ in front of ./gradlew to make it work on Windows, too. |
Yes, the issue turned out to be that some names are hard-coded and depend on how the checkout name is. I did that now in https://github.com/StefanOltmann/cloudflare-steam-name-update-service and got it working. Thank you. |
I borrowed the idea for appending the default export logic from this PR. https://github.com/cloudflare/kotlin-worker-hello-world/pull/5/files#diff-32a67597b31ada0ad6939d90a911ffc57238ecf93bd77a3fa110f7f62863c5b4R30-R51
Closes #4 #8