Skip to content

Add element.onEndTag js binding#263

Merged
kornelski merged 2 commits intocloudflare:masterfrom
taina0407:master
Mar 7, 2025
Merged

Add element.onEndTag js binding#263
kornelski merged 2 commits intocloudflare:masterfrom
taina0407:master

Conversation

@taina0407
Copy link
Contributor

This PR is to support onEndTag for JS API.
This is the first time I'm working on a Rust project so feel free to suggest any changes

@kornelski
Copy link
Contributor

There's only one EndTag type, so the macro for defining mutation methods seems unnecessary?

@taina0407
Copy link
Contributor Author

There's only one EndTag type, so the macro for defining mutation methods seems unnecessary?

You are right. The problem here is EndTag seems missing removed property, so I changed the PR to adding this so we can re-use existing impl_mutations macro instead.

@kornelski
Copy link
Contributor

Looks good. Small nit: the comment for removed is a copypaste error

@taina0407
Copy link
Contributor Author

@kornelski thankyou, amend the commit to change "comment" to "end tag" :)

@kornelski kornelski enabled auto-merge (rebase) March 7, 2025 12:31
@kornelski kornelski merged commit e95998e into cloudflare:master Mar 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants