GraphQL MCP Server #158
GraphQL MCP Server #158
Conversation
|
@Maximo-Guk can i get a review and get this merged? Do i need to get it deployed first? I'm still in the middle of getting the oauth for staging/prod. |
Changes look good to me! Just left a few minor comments, yes it would be great if you could manually deploy it first! Let me know if I can be of any help with deploying! |
Cool. thanks I'll go through your comment. I did deploy already to staging/production and seems working good. |
|
@Maximo-Guk i went through all the comments (except one thing). wdyt? |
lgtm! ( assuming CI passes ) |
|
Looks like we just need to fix CI ( unfortunately this PR comes from a fork so I had to push it up to a branch on mcp-server-cloudflare repo to get CI to run, but you can test linting locally by running the same commands that CI runs ) Also, we should update the top level README.md to include this new server! |
| MCP_SERVER_VERSION: "<PLACEHOLDER>" | "1.0.0"; | ||
| CLOUDFLARE_CLIENT_ID: string; | ||
| CLOUDFLARE_CLIENT_SECRET: string; | ||
| MCP_OBJECT: DurableObjectNamespace<import("./src/graphql.app").GraphQLMCP>; |
There was a problem hiding this comment.
@Maximo-Guk any clue why I get this line 3-16, when i ran npx wrangler types? I don't see this generated for other apps.
There was a problem hiding this comment.
We should use pnpm types https://github.com/cloudflare/mcp-server-cloudflare/pull/158/files#diff-3081a69eb973512fc1107c07bfad799453d553915ddd2b0b512c5371ee1f4f52R11 which runs wrangler types --include-env=false omitting the env's from the codegenerated types file ( since we already have the context file that contains the types for the env's )
cf-ypark
force-pushed
the
graphql-mcp
branch
2 times, most recently
from
a094bc9 to
e3cad4e
Compare
2 participants
This is for GraphQL MCP Server.