Add auth server for handling callbacks #49
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maximo-Guk
force-pushed
the
add-auth-server-for-handling-callbacks
branch
2 times, most recently
from
8b44f0c to
436f0a0
Compare
Maximo-Guk
force-pushed
the
add-auth-server-for-handling-callbacks
branch
from
436f0a0 to
4c1dc21
Compare
Member
Author
|
Closing as we decided against this in favour of having each server responsible for it's own callbacks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new auth-server app which is responsible for handling callbacks from Cloudflare oauth flow, and then redirecting them to a whitelisted server's callback URL e.g workers/observability/oauth/callback.
This simplifies the oauth authentication implementation for MCP servers within this monorepo, as each MCP server simply needs to be added to the whitelisted callback url list and then each server can handle the forwarded callback from auth-server.