Don't use resources for file list #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deloreyj
approved these changes
Apr 18, 2025
| type: 'resource', | ||
| resource: { | ||
| text: await blob.text(), | ||
| uri: `file://`, |
Collaborator
There was a problem hiding this comment.
Can you explain this line to me? Will blob.text() have the file names since you passed a directory to it?
Collaborator
Author
There was a problem hiding this comment.
Yep! blob.text() will have the list of files since a directory was passed in to container_file_read. If you look at the tool call below this for reading files, there's an if statement related to whether or not the path provided was a directory. This copies the condition where the passed path is a directory.
Collaborator
Author
There was a problem hiding this comment.
I put an image from the inspector in the description too, if that helps!
courtney-sims
force-pushed
the
wp-1580-courtney
branch
from
bb1b1f7 to
fa5cbe3
Compare
courtney-sims
force-pushed
the
fix-file-list
branch
4 times, most recently
from
929d2d6 to
4f77716
Compare
courtney-sims
force-pushed
the
fix-file-list
branch
from
4f77716 to
354ccbb
Compare
deloreyj
pushed a commit
that referenced
this pull request
Apr 22, 2025
* Update read tool call * prettier * make file write labeling consistent * Update read and write tools descriptions * prettier * Don't use resources for file list * prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets file list working by using file read to list files in the cwd while we wait on improved resource support