Skip to content

Strip hop-by-hop headers in H1 upstream proxy #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nbarbier-265 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Strip hop-by-hop headers in H1 upstream proxy #734

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d2eeb7
Strip hop-by-hop headers in H1 upstream proxy
nbarbier-265 Nov 9, 2025
e20c740
Preserve Connection and Upgrade headers for websocket upgrades
nbarbier-265 Nov 9, 2025
c39dcf5
Fix cargo fmt formatting
nbarbier-265 Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions pingora-proxy/src/proxy_h1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,22 @@ impl<SV> HttpProxy<SV> {

let mut req = session.req_header().clone();

// Strip hop-by-hop headers per RFC 2616 Section 13.5.1
// Exception: preserve Connection and Upgrade headers for websocket upgrades
let is_upgrade =
req.version == Version::HTTP_11 && req.headers.get(&http::header::UPGRADE).is_some();

if !is_upgrade {
req.remove_header(&http::header::CONNECTION);
req.remove_header(&http::header::UPGRADE);
}
req.remove_header("keep-alive");
req.remove_header("proxy-connection");
req.remove_header(&http::header::PROXY_AUTHENTICATE);
req.remove_header(&http::header::PROXY_AUTHORIZATION);
req.remove_header(&http::header::TE);
req.remove_header("trailer");

// Convert HTTP2 headers to H1
if req.version == Version::HTTP_2 {
req.set_version(Version::HTTP_11);
Expand Down