fix(proxy): Race cache lock wait against client disconnect detection #797
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cache_lock_wait_or_disconnect()which usestokio::select!to race cache lock wait against client disconnect detectionProblem
When multiple clients request the same uncached resource:
WritePermit) and fetches from originReadLock) and wait for the writerThis wasted server resources and caused delays, particularly noticeable with long lock timeouts.
Solution
Race the cache lock wait against client disconnect detection:
Protocol Support
poll_reset()Test plan
test_cache_lock_reader_client_disconnect- basic disconnect testtest_cache_lock_reader_disconnect_timing- timing regression test that fails without the fix🤖 Generated with Claude Code