Skip to content

Better handle unsupported APIs#1245

Merged
prymitive merged 1 commit intomainfrom
apis
Jan 6, 2025
Merged

Better handle unsupported APIs#1245
prymitive merged 1 commit intomainfrom
apis

Conversation

@prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.69.1-37-ge07facd
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@github-actions
Copy link

github-actions bot commented Jan 6, 2025

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   39.31m ± 2%   39.41m ± 3%       ~ (p=0.481 n=10)
CheckRules-4     8.493 ± 2%    8.512 ± 2%       ~ (p=0.796 n=10)
geomean         577.8m        579.2m       +0.25%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.40Mi ± 0%   27.40Mi ± 0%       ~ (p=0.123 n=10)
CheckRules-4    979.5Mi ± 0%   978.9Mi ± 0%       ~ (p=0.684 n=10)
geomean         163.8Mi        163.8Mi       -0.03%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.7k ± 0%   131.7k ± 0%       ~ (p=0.302 n=10)
CheckRules-4    14.16M ± 0%   14.16M ± 0%       ~ (p=0.853 n=10)
geomean         1.366M        1.366M       -0.01%

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.11%. Comparing base (e45314c) to head (e07facd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1245   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files         105      105           
  Lines       12599    12618   +19     
=======================================
+ Hits        11983    12002   +19     
  Misses        468      468           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit e345506 into main Jan 6, 2025
20 checks passed
@prymitive prymitive deleted the apis branch January 6, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants