Skip to content

Check for dead labels in joins#1605

Merged
prymitive merged 2 commits intomainfrom
promql/impssible
Nov 11, 2025
Merged

Check for dead labels in joins#1605
prymitive merged 2 commits intomainfrom
promql/impssible

Conversation

@prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.76.1-47-g95ccf446
Number of rules parsed 9
Number of rules checked 9
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.07%. Comparing base (5a89c5b) to head (95ccf44).
⚠️ Report is 62 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1605      +/-   ##
==========================================
+ Coverage   97.02%   97.07%   +0.04%     
==========================================
  Files         109      109              
  Lines       13011    13233     +222     
==========================================
+ Hits        12624    12846     +222     
  Misses        255      255              
  Partials      132      132              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
                    │   old.txt    │              new.txt               │
                    │    sec/op    │    sec/op     vs base              │
GlobFinder-4          30.55m ± ∞ ¹   30.37m ± ∞ ¹       ~ (p=0.548 n=5)
GitFinder-4           393.5m ± ∞ ¹   392.1m ± ∞ ¹       ~ (p=0.841 n=5)
CheckRules-4           9.476 ± ∞ ¹    9.496 ± ∞ ¹       ~ (p=0.690 n=5)
RuleIsIdentical-4     5.874m ± ∞ ¹   5.817m ± ∞ ¹  -0.97% (p=0.032 n=5)
GetChecksForEntry-4   111.8m ± ∞ ¹   113.2m ± ∞ ¹  +1.28% (p=0.016 n=5)
geomean               149.6m         149.4m        -0.09%
¹ need >= 6 samples for confidence interval at level 0.95

                    │    old.txt    │                new.txt                 │
                    │     B/op      │      B/op       vs base                │
GlobFinder-4          9.493Mi ± ∞ ¹    9.494Mi ± ∞ ¹       ~ (p=0.548 n=5)
GitFinder-4           19.26Mi ± ∞ ¹    19.25Mi ± ∞ ¹       ~ (p=0.841 n=5)
CheckRules-4          992.1Mi ± ∞ ¹   1018.0Mi ± ∞ ¹  +2.62% (p=0.008 n=5)
RuleIsIdentical-4       0.000 ± ∞ ¹      0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
GetChecksForEntry-4   56.55Mi ± ∞ ¹    56.55Mi ± ∞ ¹       ~ (p=0.690 n=5)
geomean                           ³                   +0.51%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

                    │   old.txt    │               new.txt                │
                    │  allocs/op   │  allocs/op    vs base                │
GlobFinder-4          145.8k ± ∞ ¹   145.8k ± ∞ ¹       ~ (p=0.825 n=5)
GitFinder-4           185.3k ± ∞ ¹   185.3k ± ∞ ¹       ~ (p=0.198 n=5)
CheckRules-4          14.73M ± ∞ ¹   14.98M ± ∞ ¹  +1.66% (p=0.008 n=5)
RuleIsIdentical-4      0.000 ± ∞ ¹    0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
GetChecksForEntry-4   915.8k ± ∞ ¹   915.8k ± ∞ ¹       ~ (p=0.905 n=5)
geomean                          ³                 +0.33%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

pkg: github.com/cloudflare/pint/internal/parser
        │   old.txt    │            new.txt            │
        │    sec/op    │    sec/op     vs base         │
Parse-4   27.67m ± ∞ ¹   27.69m ± ∞ ¹  ~ (p=0.222 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

        │    old.txt    │            new.txt             │
        │     B/op      │     B/op       vs base         │
Parse-4   8.547Mi ± ∞ ¹   8.548Mi ± ∞ ¹  ~ (p=0.579 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

        │   old.txt    │            new.txt            │
        │  allocs/op   │  allocs/op    vs base         │
Parse-4   144.9k ± ∞ ¹   144.9k ± ∞ ¹  ~ (p=0.905 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

pkg: github.com/cloudflare/pint/internal/parser/utils
               │   old.txt    │               new.txt                │
               │    sec/op    │    sec/op     vs base                │
LabelsSource-4   1.712m ± ∞ ¹   5.026m ± ∞ ¹  +193.56% (p=0.008 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

               │    old.txt    │                new.txt                │
               │     B/op      │     B/op       vs base                │
LabelsSource-4   1.352Mi ± ∞ ¹   4.083Mi ± ∞ ¹  +202.01% (p=0.008 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

               │   old.txt    │               new.txt                │
               │  allocs/op   │  allocs/op    vs base                │
LabelsSource-4   10.24k ± ∞ ¹   33.54k ± ∞ ¹  +227.39% (p=0.008 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

pkg: github.com/cloudflare/pint/internal/promapi
                    │   old.txt    │              new.txt               │
                    │    sec/op    │    sec/op     vs base              │
QueryCacheOnlySet-4   103.3n ± ∞ ¹   104.1n ± ∞ ¹       ~ (p=0.651 n=5)
QueryCacheSetGrow-4   390.8n ± ∞ ¹   364.0n ± ∞ ¹  -6.86% (p=0.016 n=5)
QueryCacheGetMiss-4   16.29n ± ∞ ¹   16.32n ± ∞ ¹       ~ (p=0.429 n=5)
QueryCacheGC/0%-4     33.92µ ± ∞ ¹   33.96µ ± ∞ ¹       ~ (p=0.841 n=5)
QueryCacheGC/1%-4     34.78µ ± ∞ ¹   34.14µ ± ∞ ¹       ~ (p=0.841 n=5)
QueryCacheGC/10%-4    38.93µ ± ∞ ¹   38.59µ ± ∞ ¹       ~ (p=0.548 n=5)
QueryCacheGC/20%-4    67.67µ ± ∞ ¹   67.39µ ± ∞ ¹       ~ (p=0.421 n=5)
QueryCacheGC/25%-4    67.16µ ± ∞ ¹   66.76µ ± ∞ ¹       ~ (p=0.151 n=5)
QueryCacheGC/50%-4    65.11µ ± ∞ ¹   65.33µ ± ∞ ¹       ~ (p=0.310 n=5)
QueryCacheGC/75%-4    49.29µ ± ∞ ¹   49.65µ ± ∞ ¹       ~ (p=0.690 n=5)
QueryCacheGC/99%-4    49.47µ ± ∞ ¹   50.17µ ± ∞ ¹       ~ (p=0.095 n=5)
QueryCacheGC/100%-4   48.89µ ± ∞ ¹   49.42µ ± ∞ ¹       ~ (p=0.222 n=5)
geomean               10.05µ         10.00µ        -0.52%
¹ need >= 6 samples for confidence interval at level 0.95

                    │    old.txt    │                new.txt                │
                    │     B/op      │     B/op       vs base                │
QueryCacheOnlySet-4     64.00 ± ∞ ¹     64.00 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheSetGrow-4     118.0 ± ∞ ¹     110.0 ± ∞ ¹  -6.78% (p=0.040 n=5)
QueryCacheGetMiss-4     0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/0%-4       0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/1%-4       0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/10%-4      0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/20%-4    18.09Ki ± ∞ ¹   18.09Ki ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/25%-4    18.09Ki ± ∞ ¹   18.09Ki ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/50%-4    18.09Ki ± ∞ ¹   18.09Ki ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/75%-4      48.00 ± ∞ ¹     48.00 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/99%-4      48.00 ± ∞ ¹     48.00 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/100%-4     48.00 ± ∞ ¹     48.00 ± ∞ ¹       ~ (p=1.000 n=5) ²
geomean                           ³                  -0.58%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

                    │   old.txt   │               new.txt               │
                    │  allocs/op  │  allocs/op   vs base                │
QueryCacheOnlySet-4   1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheSetGrow-4   1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGetMiss-4   0.000 ± ∞ ¹   0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/0%-4     0.000 ± ∞ ¹   0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/1%-4     0.000 ± ∞ ¹   0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/10%-4    0.000 ± ∞ ¹   0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/20%-4    4.000 ± ∞ ¹   4.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/25%-4    4.000 ± ∞ ¹   4.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/50%-4    4.000 ± ∞ ¹   4.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/75%-4    1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/99%-4    1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/100%-4   1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
geomean                         ³                +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

@prymitive prymitive force-pushed the promql/impssible branch 11 times, most recently from 379866a to 55358f5 Compare November 11, 2025 11:37
@prymitive prymitive merged commit 6f43db4 into main Nov 11, 2025
21 checks passed
@prymitive prymitive deleted the promql/impssible branch November 11, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants