Use pointers for Entry

[prymitive]

No description provided.

[github-actions]

This pull request was validated by pint.

✔️ No problems found

Stats

Stat	Value
Version	v0.77.1-9-g1ecb1c2d
Number of rules parsed	9
Number of rules checked	9
Number of problems found	0
Number of offline checks	0
Number of online checks	0
Checks duration	0

Problems

No problems reported

[github-actions]

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
                    │   old.txt    │              new.txt               │
                    │    sec/op    │    sec/op     vs base              │
GlobFinder-4          29.43m ± ∞ ¹   29.23m ± ∞ ¹       ~ (p=0.548 n=5)
GitFinder-4           384.7m ± ∞ ¹   384.7m ± ∞ ¹       ~ (p=1.000 n=5)
CheckRules-4           9.459 ± ∞ ¹    9.469 ± ∞ ¹       ~ (p=0.841 n=5)
RuleIsIdentical-4     5.884m ± ∞ ¹   5.857m ± ∞ ¹  -0.47% (p=0.032 n=5)
GetChecksForEntry-4   108.2m ± ∞ ¹   108.3m ± ∞ ¹       ~ (p=0.690 n=5)
geomean               146.8m         146.5m        -0.19%
¹ need >= 6 samples for confidence interval at level 0.95

                    │    old.txt     │                new.txt                 │
                    │      B/op      │      B/op       vs base                │
GlobFinder-4           9.330Mi ± ∞ ¹    8.883Mi ± ∞ ¹  -4.80% (p=0.008 n=5)
GitFinder-4            19.10Mi ± ∞ ¹    17.72Mi ± ∞ ¹  -7.23% (p=0.008 n=5)
CheckRules-4          1023.7Mi ± ∞ ¹   1021.5Mi ± ∞ ¹       ~ (p=0.222 n=5)
RuleIsIdentical-4        0.000 ± ∞ ¹      0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
GetChecksForEntry-4    56.55Mi ± ∞ ¹    56.55Mi ± ∞ ¹       ~ (p=1.000 n=5)
geomean                            ³                   -2.49%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

                    │   old.txt    │               new.txt                │
                    │  allocs/op   │  allocs/op    vs base                │
GlobFinder-4          140.4k ± ∞ ¹   141.0k ± ∞ ¹  +0.39% (p=0.008 n=5)
GitFinder-4           179.9k ± ∞ ¹   180.5k ± ∞ ¹  +0.31% (p=0.008 n=5)
CheckRules-4          15.00M ± ∞ ¹   15.00M ± ∞ ¹       ~ (p=0.056 n=5)
RuleIsIdentical-4      0.000 ± ∞ ¹    0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
GetChecksForEntry-4   915.8k ± ∞ ¹   915.8k ± ∞ ¹       ~ (p=0.643 n=5)
geomean                          ³                 +0.13%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

pkg: github.com/cloudflare/pint/internal/parser
        │   old.txt    │            new.txt            │
        │    sec/op    │    sec/op     vs base         │
Parse-4   26.95m ± ∞ ¹   27.28m ± ∞ ¹  ~ (p=0.151 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

        │    old.txt    │            new.txt             │
        │     B/op      │     B/op       vs base         │
Parse-4   8.379Mi ± ∞ ¹   8.379Mi ± ∞ ¹  ~ (p=0.151 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

        │   old.txt    │              new.txt               │
        │  allocs/op   │  allocs/op    vs base              │
Parse-4   139.4k ± ∞ ¹   139.4k ± ∞ ¹  +0.00% (p=0.032 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

pkg: github.com/cloudflare/pint/internal/parser/utils
               │   old.txt    │            new.txt            │
               │    sec/op    │    sec/op     vs base         │
LabelsSource-4   5.034m ± ∞ ¹   5.031m ± ∞ ¹  ~ (p=0.421 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

               │    old.txt    │            new.txt             │
               │     B/op      │     B/op       vs base         │
LabelsSource-4   4.084Mi ± ∞ ¹   4.086Mi ± ∞ ¹  ~ (p=0.841 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

               │   old.txt    │            new.txt            │
               │  allocs/op   │  allocs/op    vs base         │
LabelsSource-4   33.54k ± ∞ ¹   33.54k ± ∞ ¹  ~ (p=1.000 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

pkg: github.com/cloudflare/pint/internal/promapi
                    │   old.txt    │              new.txt               │
                    │    sec/op    │    sec/op     vs base              │
QueryCacheOnlySet-4   102.7n ± ∞ ¹   102.7n ± ∞ ¹       ~ (p=0.810 n=5)
QueryCacheSetGrow-4   393.1n ± ∞ ¹   381.8n ± ∞ ¹       ~ (p=0.548 n=5)
QueryCacheGetMiss-4   16.29n ± ∞ ¹   16.29n ± ∞ ¹       ~ (p=0.556 n=5)
QueryCacheGC/0%-4     34.38µ ± ∞ ¹   33.52µ ± ∞ ¹  -2.50% (p=0.008 n=5)
QueryCacheGC/1%-4     34.80µ ± ∞ ¹   34.78µ ± ∞ ¹       ~ (p=1.000 n=5)
QueryCacheGC/10%-4    38.88µ ± ∞ ¹   38.54µ ± ∞ ¹       ~ (p=0.421 n=5)
QueryCacheGC/20%-4    68.04µ ± ∞ ¹   67.23µ ± ∞ ¹  -1.19% (p=0.032 n=5)
QueryCacheGC/25%-4    67.50µ ± ∞ ¹   67.42µ ± ∞ ¹       ~ (p=0.841 n=5)
QueryCacheGC/50%-4    65.46µ ± ∞ ¹   66.33µ ± ∞ ¹       ~ (p=0.056 n=5)
QueryCacheGC/75%-4    49.84µ ± ∞ ¹   50.29µ ± ∞ ¹       ~ (p=0.222 n=5)
QueryCacheGC/99%-4    50.33µ ± ∞ ¹   50.66µ ± ∞ ¹       ~ (p=0.222 n=5)
QueryCacheGC/100%-4   49.55µ ± ∞ ¹   50.45µ ± ∞ ¹       ~ (p=0.151 n=5)
geomean               10.11µ         10.09µ        -0.25%
¹ need >= 6 samples for confidence interval at level 0.95

                    │    old.txt    │                new.txt                │
                    │     B/op      │     B/op       vs base                │
QueryCacheOnlySet-4     64.00 ± ∞ ¹     64.00 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheSetGrow-4     135.0 ± ∞ ¹     135.0 ± ∞ ¹       ~ (p=0.889 n=5)
QueryCacheGetMiss-4     0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/0%-4       0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/1%-4       0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/10%-4      0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/20%-4    18.09Ki ± ∞ ¹   18.09Ki ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/25%-4    18.09Ki ± ∞ ¹   18.09Ki ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/50%-4    18.09Ki ± ∞ ¹   18.09Ki ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/75%-4      48.00 ± ∞ ¹     48.00 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/99%-4      48.00 ± ∞ ¹     48.00 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/100%-4     48.00 ± ∞ ¹     48.00 ± ∞ ¹       ~ (p=1.000 n=5) ²
geomean                           ³                  +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

                    │   old.txt   │               new.txt               │
                    │  allocs/op  │  allocs/op   vs base                │
QueryCacheOnlySet-4   1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheSetGrow-4   1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGetMiss-4   0.000 ± ∞ ¹   0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/0%-4     0.000 ± ∞ ¹   0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/1%-4     0.000 ± ∞ ¹   0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/10%-4    0.000 ± ∞ ¹   0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/20%-4    4.000 ± ∞ ¹   4.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/25%-4    4.000 ± ∞ ¹   4.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/50%-4    4.000 ± ∞ ¹   4.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/75%-4    1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/99%-4    1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/100%-4   1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
geomean                         ³                +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.07%. Comparing base (7ee4d85) to head (1ecb1c2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1621   +/-   ##
=======================================
  Coverage   97.07%   97.07%           
=======================================
  Files         109      109           
  Lines       13230    13230           
=======================================
  Hits        12843    12843           
  Misses        255      255           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.