Skip to content

Comments

Fix checkstyle severity level mappings#1702

Merged
prymitive merged 3 commits intocloudflare:mainfrom
jzandbergen:main
Feb 4, 2026
Merged

Fix checkstyle severity level mappings#1702
prymitive merged 3 commits intocloudflare:mainfrom
jzandbergen:main

Conversation

@jzandbergen
Copy link
Contributor

This PR addresses #1225.

It maps the the following Pint Severity levels to their appropriate Checkstyle
counterpart:

Pint severity Checkstyle severity
Information info
Warning warning
Bug error
Fatal error
Unknown or not yet invented error

The reasoning for mapping an "Unknown or not yet invented" pint severity to
checkstyle error rather be notified of a unimportant message than to miss
an important message.

Note: I've took the liberty to change the Checkstyle severities to lowercase as
it is specified in the checkstyle severity types

@jzandbergen jzandbergen changed the title Fix checkstyle severity level mappings (#1225) Fix checkstyle severity level mappings Feb 4, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.56%. Comparing base (6137d37) to head (62c6bce).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1702   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files         109      109           
  Lines       13203    13215   +12     
=======================================
+ Hits        13146    13158   +12     
  Misses         32       32           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@prymitive prymitive merged commit 72a4096 into cloudflare:main Feb 4, 2026
17 of 18 checks passed
@jzandbergen
Copy link
Contributor Author

🎉 Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants