Open
Conversation
armfazh
changed the title
mendess
reviewed
Feb 20, 2026
Comment on lines
-13
to
17
| "rootDir": "src" | ||
| "rootDir": "." | ||
| }, | ||
| "include": ["src"], | ||
| "exclude": ["node_modules", "dist", "test"] | ||
| "exclude": ["node_modules", "dist"] | ||
| } |
Contributor
There was a problem hiding this comment.
what does this do? Is it relevant to this PR?
Contributor
Author
There was a problem hiding this comment.
before running npm run test:e2e failed to compile the test files.
Contributor
There was a problem hiding this comment.
wouldn't the rootDir change above address that already? agree with @mendess it's a big confusing. maybe test:e2e should have a dedicated tsconfig.json
thibmeu
reviewed
Feb 23, 2026
| "types": "dist/types/index.d.ts", | ||
| "main": "dist/worker.mjs", | ||
| "license": "Apache-2.0", | ||
| "lockfileVersion": 3, |
Contributor
There was a problem hiding this comment.
TIL this could be specified in package.json https://docs.npmjs.com/cli/v9/configuring-npm/package-lock-json#lockfileversion
Comment on lines
+42
to
+43
| "@types/node": "25.2.3", | ||
| "@types/node-fetch": "2.6.13", |
Comment on lines
-13
to
17
| "rootDir": "src" | ||
| "rootDir": "." | ||
| }, | ||
| "include": ["src"], | ||
| "exclude": ["node_modules", "dist", "test"] | ||
| "exclude": ["node_modules", "dist"] | ||
| } |
Contributor
There was a problem hiding this comment.
wouldn't the rootDir change above address that already? agree with @mendess it's a big confusing. maybe test:e2e should have a dedicated tsconfig.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix cwe117 vuln reported by sempgrep.
Fixes test:e2e compilation by including @types/node dependency.