add: FuzzVerifyReply seed #68
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
diff --git a/protocol/protocol_test.go b/protocol/protocol_test.go
index eda8453..2b4aa2c 100644
--- a/protocol/protocol_test.go
+++ b/protocol/protocol_test.go
@@ -207,6 +207,10 @@ func TestRunTestVectors(t *testing.T) {
if !bytes.Equal(replies[i], expectedReply) {
t.Error("unexpected reply")
}
+ // Print out the bytes before verification
+ t.Logf("replyBytes=%x", replies[i])
+ t.Logf("publicKey=%x", rootPublicKey)
+ t.Logf("nonce=%x", requests[i].Nonce)
// Make sure the responses verify properly.
_, _, err = VerifyReply([]Version{responseVer}, replies[i], rootPublicKey, requests[i].Nonce)
For these FP(false positive) crash, I guess. https://oss-fuzz.com/testcase-detail/6652266200760320 |
Signed-off-by: Arjun <[email protected]>
pkillarjun
force-pushed
the
update-fuzzing
branch
from
e1f5069 to
66c7c41
Compare
armfazh
requested changes
Dec 12, 2024
|
|
||
| for _, ver := range allVersions { | ||
| _, _, _ = VerifyReply([]Version{ver}, replyBytes, publicKey, nonce) | ||
| _, _, _ = VerifyReply([]Version{ver}, parts[0], parts[1], parts[2]) |
There was a problem hiding this comment.
does the error returned by VerifyReply should be catched and reported as t.Fatal(err)?
Contributor
Author
There was a problem hiding this comment.
Technically, this patch isn't even needed in the first place, but it is required for OSS-Fuzz.
So, it's not an actual bug but a bug in the OSS-Fuzz infrastructure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding seed corpus for
FuzzVerifyReply