-
Notifications
You must be signed in to change notification settings - Fork 10
feat: refactor client + containers to be testable, and add tests #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ghostwriternr
wants to merge
40
commits into
main
Choose a base branch
from
init-testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+31,527
−4,092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement global setup for automatic container building with unique build IDs - Add comprehensive container HTTP handler tests validating all API endpoints - Add container-client communication tests ensuring proper integration flow - Add detailed error response testing for all container error scenarios - Migrate from wrangler.toml to wrangler.jsonc for better tooling support - Update to preview vitest-pool-workers package with containerBuildId fix - Resolve Docker registry namespace issues for consistent container discovery 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🦋 Changeset detectedLatest commit: ae7dda6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
threepointone
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a complete 3-layer SDK architecture with a new container runtime implementation and comprehensive testing infrastructure.
Complete Architecture Implementation
3-Layer SDK Architecture
src/clients/
): Domain-specific clients (Command, File, Process, Port, Git, Utility) with direct response interfacessrc/sandbox.ts
): Persistent sandbox instances with request routing and session managementcontainer_src/
): Complete Bun-based execution environment with services, handlers, and middlewareContainer Runtime Implementation
ServiceResult<T>
pattern (ProcessService, FileService, GitService, PortService, SessionService)Comprehensive Testing Strategy
Multi-tier testing approach (Node.js with intelligent mocking due to vitest + Workers + Containers compatibility issues)
Testing Approach
ServiceResult<T>
pattern testing for container servicesSecurity & Reliability Improvements
Internal Architecture Improvements
ServiceResult<T>
pattern for all container business logicDeveloper Experience & Documentation
Complete Contributor Documentation
CLAUDE.md
: AI agent instructions with architectural patterns and development commandsdocs/ARCHITECTURE.md
: Detailed 3-layer system design and implementation patternsdocs/DEVELOPER_GUIDE.md
: Step-by-step contribution workflows and feature developmentdocs/TESTING.md
: Comprehensive testing strategy with service patternsCONTRIBUTING.md
: Contribution guidelines and code standardsCI/CD & Development