add docker fallback support and default namespace #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fixes to work with docker as a proxy
add default namespace
Update http.ts
gabivlj
reviewed
Nov 20, 2024
src/router.ts
Outdated
| } | ||
|
|
||
| const { name, reference } = req.params; | ||
| const { reference } = req.params; |
Collaborator
There was a problem hiding this comment.
can these library prefix logic be in the fallback client when a docker.io registry is being in use?
Contributor
Author
There was a problem hiding this comment.
niot sure where you mean the logic should be put..
Collaborator
There was a problem hiding this comment.
const name = req.params.name.includes("/") ? req.params.name : `library/${req.params.name}`;
This could probably get moved to http.ts? Seems very specific to how docker.io does things.
gabivlj
reviewed
Nov 20, 2024
Collaborator
|
Thank you so much @cberescu, I appreciate this contribution a lot ❤️. |
Contributor
Author
|
fixed some failed tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix some issues with docker hub fallback support. Also adds a default for namespaces .
Should fix #70