Marks both logpull_options and output_options as computed#5785
Closed
Cyb3r-Jak3 wants to merge 1 commit intocloudflare:v4from
Closed
Marks both logpull_options and output_options as computed#5785Cyb3r-Jak3 wants to merge 1 commit intocloudflare:v4from
Cyb3r-Jak3 wants to merge 1 commit intocloudflare:v4from
Conversation
|
changelog detected ✅ |
Cyb3r-Jak3
changed the title
|
This pull request hasn't been updated in a while, and is being marked as stale. Thanks! |
Author
|
Not stale. Still waiting on review |
Member
|
Hi @Cyb3r-Jak3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
Fixes an issue where the v4 provider has perma-drift due to the API setting both
logpull_optionsandoutput_optionsbut the current provider only expecting one to be set.I also removed some err checks that weren't being used, as they were checking errors that would be already checked.
Additional context & links
Similar to #5578, but this fix is for the v4 provider.