Fix list items polling during async creation and add acceptance tests #5881
+309
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
vaishakdinesh
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Implements polling the asynchronous operation that results from creating the list item. This also specifies that the list items cannot be updated, requiring recreation on changes.
This implementation is limited in functionality for large lists, those with lots of items, due to the pagination implementation being broken at the moment. This should cover most uses for now until that is fixed.
Additional context & links
https://developers.cloudflare.com/api/resources/rules/subresources/lists/subresources/items/methods/create/
Supersedes #5854