Skip to content

Conversation

@mya-jin
Copy link
Contributor

@mya-jin mya-jin commented Feb 3, 2026

  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

The unit.id update should trigger recreate, so need to add the planModifier stringplanmodifier.RequiresReplace(),, and a plan check should be added to acceptance tests to make sure updating unit.id would trigger destroy and create.

Acceptance test run results

  • I have added or updated acceptance tests for my changes
  • I have run acceptance tests for my changes and included the results below

Steps to run acceptance tests

Test output

mya@G9JRYWDQ25 terraform-provider-cloudflare % cd ./internal/services/account && TF_LOG='' go test -v -run "^TestAccCloudflareAccount_WithUnit" 2>&1 | tail -5
=== RUN   TestAccCloudflareAccount_WithUnit
    resource_test.go:247: CLOUDFLARE_UNIT_ID is not set
--- SKIP: TestAccCloudflareAccount_WithUnit (0.00s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/services/account   1.540s

Additional context & links

@mya-jin mya-jin requested a review from a team as a code owner February 3, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants