feat: v4 to v5 migration for zero trust list#10
Merged
tamas-jozsa merged 1 commit intomainfrom Nov 3, 2025
Merged
Conversation
tamas-jozsa
force-pushed
the
zero_trust_list
branch
from
16a171f to
7f2e4be
Compare
tamas-jozsa
commented
Oct 31, 2025
Collaborator
Author
There was a problem hiding this comment.
Problem: The state test helper wasn't correctly simulating how the actual migration framework
works, causing test failures in account_member and dns_record resources.
Root Cause: The real migration handler (internal/handlers/state_transform.go:83) passes
individual instance objects to TransformState(), not full state documents. However, the test
helper was incorrectly passing the entire state structure.
Solution: Updated internal/testhelpers/state.go to:
- Detect and handle instance-only test inputs (no "resources" field) by passing them directly
to TransformState() - For full state tests, iterate through instances and pass each one individually to
TransformState() - matching real behavior - Properly preserve empty arrays and edge cases like empty resources
Impact: This ensures unit tests accurately validate migration behavior, preventing bugs where
migrations work in tests but fail in production.
SirCortly
approved these changes
Oct 31, 2025
tamas-jozsa
force-pushed
the
zero_trust_list
branch
2 times, most recently
from
3977d17 to
a1b9b3b
Compare
tamas-jozsa
force-pushed
the
zero_trust_list
branch
from
2274d7c to
aa3d971
Compare
kamarjago
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.