feat(logpush_job): v4 to v5 migrations

[ssicard]

1. Supports migrations of the logpush_job resource from v4 to v5. Will migrate the following:

• rename attribute in output_options of cve20214428 to cve_2021_44228
• any kind of "instant-logs" is no longer supported. It now transforms into ""
• max_upload_bytes, max_upload_records, and max_upload_interval_seconds all convert from an int to Float64
• convert output_options from block to attribute

2. Moves the function for nulling out empty values from zero_trust_device_posture_rule to a helper for use across various resources.

Assertions Made

The following assertions were made within this implementation:

• max_upload_bytes, max_upload_records, and max_upload_interval_seconds had default values of 0 in v4. This is not a valid value for any of these fields, so the tool will delete these fields to null them out to match v5 state.
• The defaults for output_options in v4 are retained as the tool migrates to v5. They will now be explicitly set in customer's config and state after migration.
• empty string defaults are nulled out to match v5 state and avoid drift

End to End Tests

The output of the end to end tests are seen below. There are two drifts, which are expected, as they are a result of kind allowing less values in v5 than in v4 for instant-logs.

Running terraform plan in v5/...
⚠ Terraform plan shows changes
  Plan: 0 to add, 2 to change, 0 to destroy.

Detailed changes:

  # module.logpush_job.cloudflare_logpush_job.full will be updated in-place
  ~ resource "cloudflare_logpush_job" "full" {
      + error_message    = (known after apply)
        id               = 1300622
      ~ kind             = "instant-logs" -> ""
      + last_complete    = (known after apply)
      + last_error       = (known after apply)
        name             = "my-logpush-job"
        # (6 unchanged attributes hidden)

  # module.logpush_job.cloudflare_logpush_job.instant_logs will be updated in-place
  ~ resource "cloudflare_logpush_job" "instant_logs" {
      + error_message    = (known after apply)
        id               = 1300615
      ~ kind             = "instant-logs" -> ""
      + last_complete    = (known after apply)
      + last_error       = (known after apply)
        # (5 unchanged attributes hidden)

This is a stale review, and substantial changes have been added since regarding:

• explicitly setting v4 defaults in the v5 config and state
• removing any kind set to "instant-logs" as the v5 default will set it to ""

[tamas-jozsa]

Could you rebase + improve the comprehensiveness of the integration testdata using prompt:subtask_08?

This review is stale.

[ssicard]

Note: the integration/e2e tests that tested instant-logs being removed from the config/state were removed after testing. A change was made in the resource.go in the provider to ignore any updates to this value, but as that is not available until a new version of the provider comes out, this test has been removed.

Some changes have been made to tests since last review