Skip to content

Comments

Nightly -> main#338

Merged
karishnu merged 2 commits intomainfrom
nightly
Feb 20, 2026
Merged

Nightly -> main#338
karishnu merged 2 commits intomainfrom
nightly

Conversation

@karishnu
Copy link
Collaborator

@karishnu karishnu commented Feb 20, 2026

Summary

Introduces a lightweight blueprint generation mode for minimal templates, reducing prompt complexity and output verbosity for simpler projects.

Changes

  • Added LitePhasicBlueprintSchema in worker/agents/schemas.ts - a streamlined schema with fewer fields (single userFlow string instead of nested object, simplified descriptions)
  • Added LITE_PHASIC_SYSTEM_PROMPT in worker/agents/planning/blueprint.ts - a concise ~800 word prompt for rapid prototyping
  • Added liteToPhasicBlueprint() conversion function to transform lite blueprints to full PhasicBlueprint format for downstream compatibility
  • Modified generateBlueprint() to detect minimal templates and use the appropriate schema/prompt

Motivation

Minimal templates don't need the full verbose blueprint with extensive UI/UX details. This reduces token usage and generation time while maintaining compatibility with the rest of the pipeline.

Testing

  • Test blueprint generation with a minimal template to verify lite mode activates
  • Test non-minimal templates to ensure they still use the full phasic blueprint
  • Verify the converted lite blueprint works correctly downstream

Related Issues

None identified

@karishnu karishnu merged commit 27b7a9b into main Feb 20, 2026
8 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026

Claude finished @karishnu's task in 1m 25s —— View job


Code Quality & Security Review

Recommendation: APPROVE

PR Summary

Introduces a lightweight blueprint generation mode for minimal templates, reducing prompt complexity and output verbosity for simpler projects while maintaining downstream compatibility.

PR Description

  • Updated: Yes
  • Notes: Generated complete description with summary, changes, motivation, and testing notes

Addressed Issues

  • None identified

Code Quality

Severity Count Details
Critical 0 -
High 0 -
Medium 1 Template detection logic
Low 2 Empty string defaults, redundant spread

Medium - Template Detection Logic (blueprint.ts:368)

const isLiteTemplate = !isAgentic && templateDetails?.name?.includes('minimal');

The string matching is case-sensitive and could match unintended templates. Consider:

  • Using .toLowerCase().includes('minimal') for case insensitivity
  • Or using a more explicit check like exact template name matching

Fix this →

Low - Empty String Defaults (blueprint.ts:293-295)
The liteToPhasicBlueprint function sets uiDesign and userJourney to empty strings. This works but downstream code should handle empty values gracefully.

Low - Redundant Property Assignments (blueprint.ts:289-302)
The spread ...lite includes properties that are then explicitly reassigned. This is intentional for clarity but slightly redundant.


Security

Severity Count Details
Critical 0 -
High 0 -
Medium 0 -
Low 0 -

No security concerns - internal blueprint generation logic with proper Zod schema validation.


Testing

  • Manual testing recommended with minimal and non-minimal templates
  • Verify liteToPhasicBlueprint conversion produces valid downstream blueprints

Positive Observations

  • Clean implementation following existing codebase patterns
  • Type safety maintained with proper Zod schemas and TypeScript types
  • Good separation of concerns (schema, prompt, conversion function)
  • Backward compatible - converts lite blueprints to full format

Final Recommendation

Approve - Well-implemented feature with minor suggestions for improvement. The medium-severity template detection issue is a robustness concern rather than a bug.


Tasks Completed

  • Gather context (CLAUDE.md, PR diff)
  • Review PR description
  • Analyze code changes for quality & security
  • Post comprehensive review summary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant