Skip to content

remove experimental attribute from enableNodejsHttpServerModules #4722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

remove experimental attribute from enableNodejsHttpServerModules #4722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/workerd/api/node/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,7 @@ void registerNodeJsCompatModules(Registry& registry, auto featureFlags) {
// We put node:_http_server and related features behind a compat flag
// for securing backward compatibility.
if (isNodeHttpServerModule(module.getName())) {
return featureFlags.getEnableNodejsHttpServerModules() &&
featureFlags.getWorkerdExperimental();
return featureFlags.getEnableNodejsHttpServerModules();
}

if (isNodeOsModule(module.getName())) {
Expand Down
4 changes: 1 addition & 3 deletions src/workerd/io/compatibility-date.capnp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,7 +893,7 @@ struct CompatibilityFlags @0x8f8c1b68151b6cef {
enableNodejsHttpServerModules @103 :Bool
$compatEnableFlag("enable_nodejs_http_server_modules")
$compatDisableFlag("disable_nodejs_http_server_modules")
$experimental;
$impliedByAfterDate(name = "enableNodejsHttpModules", date = "2025-09-01");
# Enables Node.js http server related modules such as node:_http_server
# This flag is experimental and may change or be removed in future versions.
# It is required to use this flag with `enable_nodejs_http_modules` since
Expand All @@ -902,8 +902,6 @@ struct CompatibilityFlags @0x8f8c1b68151b6cef {
# Regarding the recommendation for using import { env, waitUntil } from 'cloudflare:workers';
# `disallow_importable_env` compat flag should not be set if you are using this
# and need access to the env since that will prevent access.
# TODO(soon): Add a implifiedByAfter when node.js is enabled as well as
# `enable_nodejs_http_modules`

pythonNoGlobalHandlers @104 :Bool
$compatEnableFlag("python_no_global_handlers")
Expand Down