[build] Clean up more capnp embeds/expand #embed usage #4737
+57
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
force-pushed
the
felix/080825-embed-cleanup
branch
from
ab925df to
911cf10
Compare
npaun
approved these changes
Aug 10, 2025
jasnell
approved these changes
Aug 10, 2025
fhanau
force-pushed
the
felix/080825-embed-cleanup
branch
from
911cf10 to
f46d6f6
Compare
No more 57MB c++ file for icu-data!
fhanau
force-pushed
the
felix/080825-embed-cleanup
branch
from
f46d6f6 to
de185a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more 57MB c++ file for icu-data!