Skip to content

Conversation

@alexeagle
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@alexeagle alexeagle changed the title refactor(bazel): move pyoxide to bzlmod refactor(bazel): move pyodide to bzlmod Oct 3, 2025
@alexeagle alexeagle force-pushed the alexeagle/bzlmod5 branch 6 times, most recently from fde42d6 to 3719a7e Compare October 3, 2025 19:26
@alexeagle alexeagle requested a review from fhanau October 7, 2025 20:02
@alexeagle alexeagle marked this pull request as ready for review October 7, 2025 20:02
@alexeagle alexeagle requested review from a team as code owners October 7, 2025 20:02
@alexeagle
Copy link
Collaborator Author

@fhanau could you tell me what's broken on the internal CI?

@fhanau
Copy link
Contributor

fhanau commented Oct 20, 2025

@fhanau could you tell me what's broken on the internal CI?

I believe this will require an internal PR to go with it – I'll try to get to that tomorrow.

@fhanau
Copy link
Contributor

fhanau commented Oct 21, 2025

Ok, integrating this with the internal repository will be more hairy than expected – @dom96 and @hoodmane are more with pyodide and should be able to help.

@hoodmane
Copy link
Contributor

Is there a way to do this without the duplication? It is really great having one source of truth for all of this stuff, the duplication is going to waste a very substantial amount of my time.

@hoodmane
Copy link
Contributor

For instance, maybe it's possible to make ~4 file_groups and expose those?

@alexeagle
Copy link
Collaborator Author

@hoodmane all of this happens during repository rule evaluation, so filegroup isn't a useful construct.

I've struggled with a few formulations of this and haven't found anything simpler - in fact this PR isn't sufficient on its own since the repository is still defined in WORKSPACE which is going away for Bazel 9.

Having someone with pyodide familiarily pair with me as the Bazel expert is probably the right way to find a resolution - let's chat on Slack?

@mikea
Copy link
Contributor

mikea commented Nov 6, 2025

The best (the only?) advice I have here to make things maintanable is to update pyodide build script to generate the pyodide include with all the necessary extensions. This way you will have full control of all the repositories and information won't be duplicated.

One can also imagine pyodide publishing a bzlmod-friendly package somewhere (central registry?) but that seems like a lot of work to me.

@alexeagle
Copy link
Collaborator Author

replaced by #5832 and/or 042fbb8

@alexeagle alexeagle closed this Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants