-
Notifications
You must be signed in to change notification settings - Fork 507
refactor(bazel): move pyodide to bzlmod #5232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The generated output of |
fde42d6 to
3719a7e
Compare
3719a7e to
5ad2e11
Compare
a1208a5 to
e50d6fa
Compare
7e19130 to
f463223
Compare
f463223 to
57fe01e
Compare
|
@fhanau could you tell me what's broken on the internal CI? |
I believe this will require an internal PR to go with it – I'll try to get to that tomorrow. |
|
Is there a way to do this without the duplication? It is really great having one source of truth for all of this stuff, the duplication is going to waste a very substantial amount of my time. |
|
For instance, maybe it's possible to make ~4 file_groups and expose those? |
|
@hoodmane all of this happens during repository rule evaluation, so I've struggled with a few formulations of this and haven't found anything simpler - in fact this PR isn't sufficient on its own since the repository is still defined in WORKSPACE which is going away for Bazel 9. Having someone with pyodide familiarily pair with me as the Bazel expert is probably the right way to find a resolution - let's chat on Slack? |
|
The best (the only?) advice I have here to make things maintanable is to update pyodide build script to generate the pyodide include with all the necessary extensions. This way you will have full control of all the repositories and information won't be duplicated. One can also imagine pyodide publishing a bzlmod-friendly package somewhere (central registry?) but that seems like a lot of work to me. |
No description provided.