[Instrumentation] Add attributes to synchronous KV operations #5277
+292
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmorrell-cloudflare
force-pushed
the
jmorrell/do-sql-kv-attributes
branch
from
b64842e to
c7817f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #5251
Add the following attributes to the existing spans:
durable_object_storage_kv_get
db.system.name
db.operation.name
cloudflare.durable_object.kv.query.keys
cloudflare.durable_object.kv.query.keys.count
durable_object_storage_kv_list
db.system.name
db.operation.name
cloudflare.durable_object.kv.query.start
cloudflare.durable_object.kv.query.startAfter
cloudflare.durable_object.kv.query.end
cloudflare.durable_object.kv.query.prefix
cloudflare.durable_object.kv.query.reverse
cloudflare.kv.query.limit
durable_object_storage_kv_put
db.system.name
db.operation.name
cloudflare.durable_object.kv.query.keys
cloudflare.durable_object.kv.query.keys.count
durable_object_storage_kv_delete
db.system.name
db.operation.name
cloudflare.durable_object.kv.query.keys
cloudflare.durable_object.kv.query.keys.count
cloudflare.durable_object.kv.response.deleted_count