-
Notifications
You must be signed in to change notification settings - Fork 461
feat: Add hard timeout support to container startup #5280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Talador12
commented
Oct 10, 2025
- Add hardTimeoutMs to StartupOptions struct
- Implement hard timeout RPC call during container.start()
- Add setHardTimeout @8 method to container.capnp schema
- Hard timeout is absolute from startup, unlike inactivity timeout
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
6b2a1f8 to
4ceb2b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending tests passing
4ceb2b8 to
8ee2eee
Compare
cd5f928 to
8d0beed
Compare
CodSpeed Performance ReportMerging #5280 will improve performances by 14.95%Comparing Summary
Benchmarks breakdown
Footnotes
|
76429bc to
cb06d70
Compare
cb06d70 to
f243c52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for reverting the string parsing as its inconsistent with setInactivityTimeout. we can do this one layer up in js like we do for setInactivityTimeout.
4ffc45b to
9cdc4a0
Compare
9cdc4a0 to
84bc93a
Compare
84bc93a to
f770a2a
Compare
f770a2a to
5c6a9de
Compare