Skip to content

Conversation

@Talador12
Copy link
Member

  • Add hardTimeoutMs to StartupOptions struct
  • Implement hard timeout RPC call during container.start()
  • Add setHardTimeout @8 method to container.capnp schema
  • Hard timeout is absolute from startup, unlike inactivity timeout

@Talador12 Talador12 requested review from a team as code owners October 10, 2025 19:58
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Talador12
Copy link
Member Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Oct 10, 2025
@Talador12 Talador12 force-pushed the feature/hard-timeout-startup branch 3 times, most recently from 6b2a1f8 to 4ceb2b8 Compare October 10, 2025 20:13
Copy link
Contributor

@gabivlj gabivlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending tests passing

@Talador12 Talador12 force-pushed the feature/hard-timeout-startup branch from 4ceb2b8 to 8ee2eee Compare October 13, 2025 20:44
@Talador12 Talador12 force-pushed the feature/hard-timeout-startup branch from cd5f928 to 8d0beed Compare October 22, 2025 21:06
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 22, 2025

CodSpeed Performance Report

Merging #5280 will improve performances by 14.95%

Comparing Talador12:feature/hard-timeout-startup (5c6a9de) with main (0a9873d)

Summary

⚡ 1 improvement
✅ 32 untouched
⏩ 9 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Change
Encode_ASCII_32[0/0/32] 3.6 ms 3.1 ms +14.95%

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Talador12 Talador12 force-pushed the feature/hard-timeout-startup branch 2 times, most recently from 76429bc to cb06d70 Compare October 23, 2025 15:04
@Talador12 Talador12 requested a review from a team as a code owner October 23, 2025 15:04
@Talador12 Talador12 force-pushed the feature/hard-timeout-startup branch from cb06d70 to f243c52 Compare October 23, 2025 15:04
Copy link
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for reverting the string parsing as its inconsistent with setInactivityTimeout. we can do this one layer up in js like we do for setInactivityTimeout.

@Talador12 Talador12 force-pushed the feature/hard-timeout-startup branch 4 times, most recently from 4ffc45b to 9cdc4a0 Compare October 23, 2025 16:09
@Talador12 Talador12 force-pushed the feature/hard-timeout-startup branch from 9cdc4a0 to 84bc93a Compare October 23, 2025 18:45
@Talador12 Talador12 force-pushed the feature/hard-timeout-startup branch from 84bc93a to f770a2a Compare October 23, 2025 18:47
@Talador12 Talador12 force-pushed the feature/hard-timeout-startup branch from f770a2a to 5c6a9de Compare October 23, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants