Skip to content

[o11y] Address STW destination execution context errors #5300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

[o11y] Address STW destination execution context errors #5300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/workerd/io/trace-stream.c++
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,9 +653,11 @@ class TailStreamTarget final: public rpc::TailStreamTarget::Server {
});
promise = promise.attach(kj::defer([fulfiller = kj::mv(paf.fulfiller)]() mutable {
if (fulfiller->isWaiting()) {
fulfiller->reject(JSG_KJ_EXCEPTION(FAILED, Error,
"The destination execution context for this tail session was canceled while the "
"call was still running."));
// The promise for handling events got canceled, perhaps because the request got aborted
// during a crash. There is nothing we can do to recover in that case, a previous error
// should already indicate what went wrong. Still fulfill the fulfillers so they get cleaned
// up properly.
fulfiller->fulfill();
}
}));
ioContext.addTask(kj::mv(promise));
Expand Down