Reset uncaught exception handling after startup execution #5342
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhart
changed the title
anonrig
reviewed
Oct 20, 2025
|
|
||
| // Reset this back to its default after startup execution | ||
| // Leaving it on comes at the expense of collecting stack traces for all thrown exceptions | ||
| if (script->isolate->impl->inspector == kj::none) { |
There was a problem hiding this comment.
Should we set it to false regardless of inspector? Since we use inspector for profiling as well?
anonrig
reviewed
Oct 20, 2025
| }); | ||
|
|
||
| // Reset this back to its default after startup execution | ||
| // Leaving it on comes at the expense of collecting stack traces for all thrown exceptions |
There was a problem hiding this comment.
Would you mind adding a link to the github issue, so we don't lose the context?
anonrig
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5332
I've confirmed this keeps the stack for any uncaught errors during startup:
Turning this off any earlier (eg at the end of the Script constructor) is too early:
I've also confirmed this improves performance of running scripts with
throwpatterns as per #5332