Implement TypeHandlerRegistry #5361
Draft
+427
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides a mechanism to obtain const TypeHandler<T>& references without needing to inject them via jsg argument injection.
|
The generated output of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a mechanism to obtain const TypeHandler& references without needing to inject them via jsg argument injection.
tests were implemented by claude with a bit of manual intervention.
This approach is imperfect, of course... specifically because it requires individual types to be registered. It won't automatically work for things like
const TypeHandler<jsg::Promise<T>>since it can't know about all possiblejsg::Promise<T>'s we might use, but it's good enough to investigate the utility.** THIS IS CURRENTLY JUST AN EXPLORATION OF OPTIONS **
Draft since this is still WIP/being investigate.
Internal build will fail until the same v8 patch is landed there.